Fix: keyword stuffing detection prose-density gate#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Issue #71 highlighted a case where the keyword-stuffing heuristic incorrectly flagged prose as keyword stuffing. This PR adds a minimum average words per segment check, which assumes that keyword stuffing will be 1-2 words per segment, while genuine prose will have a higher words-per-segment density.
This may still be problematic, but hopefully we're circling closer to something useful. At the very least, it solves the case reported in 71.
How to test
Adds a new test in
structure/frontmatter_test.gofor the exact description reported in 71. The new test plus all existing tests are green with this change.Checklist
go test -race ./... -count=1)golangci-lint run)